Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755269AbYFXTqb (ORCPT ); Tue, 24 Jun 2008 15:46:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752473AbYFXTqS (ORCPT ); Tue, 24 Jun 2008 15:46:18 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:50769 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbYFXTqR (ORCPT ); Tue, 24 Jun 2008 15:46:17 -0400 Date: Tue, 24 Jun 2008 12:45:51 -0700 (PDT) From: Linus Torvalds To: Miklos Szeredi cc: jens.axboe@oracle.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [rfc patch 3/4] splice: remove confirm from pipe_buf_operations In-Reply-To: Message-ID: References: <20080621154607.154640724@szeredi.hu> <20080621154726.494538562@szeredi.hu> <20080624080440.GJ20851@kernel.dk> <20080624111913.GP20851@kernel.dk> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1025 Lines: 26 On Tue, 24 Jun 2008, Miklos Szeredi wrote: > > Right. But what if it's invalidated *before* becoming uptodate (if > you'd read my mail further, I discussed this). > > Why does invalidate_complete_page2() do ClearPageUptodate()? Dunno, > maybe it shoulnd't. But that would need a rather thorough audit of > all code checking PageUptodate()... Quite frankly, that shouldn't happen in the first place. Nothing should clear up-to-date on a page that is locked. Doesn't invalidate_complete_page() wait for the page to be unlocked already? That said, the VM people already discussed (I think for other reasons), removing the ClearPageUptodate(), because it has problems. There's talk about just unhashing the page or moving it to another radix tree or something. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/