Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755681AbYFXUBh (ORCPT ); Tue, 24 Jun 2008 16:01:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752954AbYFXUB2 (ORCPT ); Tue, 24 Jun 2008 16:01:28 -0400 Received: from rv-out-0506.google.com ([209.85.198.229]:42978 "EHLO rv-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752893AbYFXUB1 (ORCPT ); Tue, 24 Jun 2008 16:01:27 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=cxv/LuMFSYt0iVrd3XhJA7pfBq33iVvOPV2KH8lFIA/kOP2H+9KiW0UVkMkfEFL6D4 VuhsprRGm/wdzgqA7mUVC3p7vtH3Uo0KbqpVggB63R9XFUNGALX/6w0Nordz1vdwBp7o SboHpdOHLF76SKhUD2FRRmd0ZHiWK8aX2hNPk= Message-ID: <86802c440806241301x4d124335h2888de9e915208ae@mail.gmail.com> Date: Tue, 24 Jun 2008 13:01:26 -0700 From: "Yinghai Lu" To: "Bernhard Walle" , "Ingo Molnar" Subject: Re: [PATCH 2/3] e820_update_range(): Allow specifying ULLONG_MAX Cc: x86@kernel.org, vgoyal@redhat.com, linux-kernel@vger.kernel.org In-Reply-To: <1214318125-32619-3-git-send-email-bwalle@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1214318125-32619-1-git-send-email-bwalle@suse.de> <1214318125-32619-3-git-send-email-bwalle@suse.de> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2327 Lines: 60 On Tue, Jun 24, 2008 at 7:35 AM, Bernhard Walle wrote: > Allow the specifying of ULLONG_MAX to limit the whole E820 map from the > specified start to the end. Without the patch, there would be integer > overflows. > > > Signed-off-by: Bernhard Walle > --- > arch/x86/kernel/e820.c | 11 +++++++++-- > 1 files changed, 9 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c > index e466073..7d1109b 100644 > --- a/arch/x86/kernel/e820.c > +++ b/arch/x86/kernel/e820.c > @@ -397,6 +397,9 @@ int __init copy_e820_map(struct e820entry *biosmap, int nr_map) > return __copy_e820_map(biosmap, nr_map); > } > > +/* > + * Pass size == ULLONG_MAX to update until the end. > + */ > u64 __init e820_update_range(u64 start, u64 size, unsigned old_type, > unsigned new_type) > { > @@ -412,14 +415,18 @@ u64 __init e820_update_range(u64 start, u64 size, unsigned old_type, > continue; > /* totally covered? */ > if (ei->addr >= start && > - (ei->addr + ei->size) <= (start + size)) { > + (((ei->addr + ei->size) <= (start + size)) || > + (size == ULLONG_MAX))) { > ei->type = new_type; > real_updated_size += ei->size; > continue; > } > /* partially covered */ > final_start = max(start, ei->addr); > - final_end = min(start + size, ei->addr + ei->size); > + if (size == ULLONG_MAX) > + final_end = ei->addr + ei->size; > + else > + final_end = min(start + size, ei->addr + ei->size); > if (final_start >= final_end) > continue; > ei->size -= final_end - final_start; > -- it seems we should let the caller to use e820_update_range(start, ULLONG_MAX - size,....) so you don't need to touch this func. YH -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/