Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755284AbYFXV4t (ORCPT ); Tue, 24 Jun 2008 17:56:49 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756603AbYFXV4N (ORCPT ); Tue, 24 Jun 2008 17:56:13 -0400 Received: from smtp5.pp.htv.fi ([213.243.153.39]:38985 "EHLO smtp5.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755587AbYFXV4D (ORCPT ); Tue, 24 Jun 2008 17:56:03 -0400 Date: Wed, 25 Jun 2008 00:54:01 +0300 From: Adrian Bunk To: David Brownell Cc: lkml , rtc-linux@googlegroups.com Subject: Re: [patch 2.6.26-rc7] space reduction Message-ID: <20080624215400.GA18252@cs181140183.pp.htv.fi> References: <200806221954.37088.david-b@pacbell.net> <20080623065034.GG20122@cs181140183.pp.htv.fi> <200806230015.49973.david-b@pacbell.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <200806230015.49973.david-b@pacbell.net> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1655 Lines: 50 On Mon, Jun 23, 2008 at 12:15:49AM -0700, David Brownell wrote: > On Sunday 22 June 2008, Adrian Bunk wrote: > > On Sun, Jun 22, 2008 at 07:54:36PM -0700, David Brownell wrote: > > > This updates to define the key routines as static > > > constant functions, which the macros will then call. > > > > > > ... Typical per-driver savings top 200 bytes. ... > > > > The patch breaks the compilation: > > Needs to #include then; "u8" isn't always known. > Or maybe just spell it out "unsigned char". > > > > ... > > > > Additionally, I'd suggest to make them out-of-line functions > > instead of shipping multiple copies in different object files. > > That was one of the options. I thought I'd start with something > simpler, and see what folk thought. > > Where would that be ... lib/bcd.c, always linked? Sounds good. > And if it goes > that way I'd prefer bcd2bin() and bin2bcd(), not these names. A > small impetus to have LESS SOURCE CODE SHOUTING AT ME. Sounds good, but start with SHOUTING COMPATIBILITY #DEFINES FOR THE EXISTING USERS and either clean them up later or let me do the cleanup. > - Dave cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/