Date: Tue, 24 Jun 2008 23:10:31 -0400 (EDT)
From: Len Brown <lenb@kernel.org>
Subject: Re: [PATCH] ACPI: add standard linux WARN() output to ACPI warnings
In-reply-to: <20080624194915.11d6aee9@infradead.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Ingo Molnar <mingo@elte.hu>, Vegard Nossum <vegard.nossum@gmail.com>,
       Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
       linux-acpi@vger.kernel.org, Zhao Yakui <yakui.zhao@intel.com>,
       "Rafael J. Wysocki" <rjw@sisk.pl>,
       Alexey Starikovskiy <astarikovskiy@suse.de>,
       Yinghai Lu <yhlu.kernel@gmail.com>
Message-id: <alpine.LFD.1.10.0806242310000.3014@localhost.localdomain>
MIME-version: 1.0
Content-type: TEXT/PLAIN; charset=US-ASCII
References: <20080620095247.GA24557@elte.hu>
 <20080620135639.GA5073@damson.getinternet.no> <20080620142224.GF8135@elte.hu>
 <alpine.LFD.1.10.0806242231120.3014@localhost.localdomain>
 <20080624194915.11d6aee9@infradead.org>
User-Agent: Alpine 1.10 (LFD 962 2008-03-14)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 607
Lines: 22


> Please do not use warn_on_slowpath() directly!
> Please use WARN_ON() or WARN(). The later has printk semantics so this
> could turn into
> 
> WARN(1, "ACPI Error (%s-%0d): \n", module_name, line_number);

> 
> and kerneloops.org and various other tools will pick up the printk like
> arguments as part of the warning message.

cool, will do.

thanks,
-Len

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/