Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759228AbYFYTkO (ORCPT ); Wed, 25 Jun 2008 15:40:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752811AbYFYTj7 (ORCPT ); Wed, 25 Jun 2008 15:39:59 -0400 Received: from ns1.suse.de ([195.135.220.2]:34325 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753305AbYFYTj6 (ORCPT ); Wed, 25 Jun 2008 15:39:58 -0400 Date: Wed, 25 Jun 2008 21:39:55 +0200 From: Bernhard Walle To: "Yinghai Lu" Cc: x86@kernel.org, linux-kernel@vger.kernel.org, vgoyal@redhat.com, kexec@lists.infradead.org Subject: Re: [PATCH 3/3] Limit E820 map when a user-defined memory map is specified Message-ID: <20080625213955.0da0fa9a@kopernikus.site> In-Reply-To: <86802c440806250958j691988c4q19278400dadf7e15@mail.gmail.com> References: <1214395342-20375-1-git-send-email-bwalle@suse.de> <1214395342-20375-4-git-send-email-bwalle@suse.de> <86802c440806250901n68278ab1ma1add38c165122af@mail.gmail.com> <20080625180319.122819ea@halley.suse.de> <86802c440806250958j691988c4q19278400dadf7e15@mail.gmail.com> Organization: SUSE LINUX Products GmbH X-Mailer: Claws Mail 3.4.0 (GTK+ 2.12.10; i686-pc-linux-gnu) X-Face: ,G!z)dEOMkc[Cu+sF64,T9^5r3b>/}#HBRL%D^j@\SZbr'Itl7q@1<*dgB?A7(_leO1Tc4^ D*WfvfwKcz;,@E^y+pNP%86n8o<&g-vToCXW:r>Y$jxY,`KT?{H!07=2|Jdt?0ba^C-Tnx50vIV8It vi&Sicl:sj`k2`y)E;ECFi;i7W-?t3%\kD*));q)+%-pQd^.r'W}oBBx=+.~Gu}&F;lS7.a-m>Rv"w pe`D'OV^?HJd$-)7<2T[naDPl6+bAj'+UYd]u]B^'.LYK$2jS Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 859 Lines: 24 * "Yinghai Lu" [2008-06-25 09:58]: > On Wed, Jun 25, 2008 at 9:03 AM, Bernhard Walle wrote: > >> only this one is needed now. but please change ULLONG_MAX to > >> ULLONG_MAX - mem_size > > > > Why can't we add that check at the beginning of e820_update_range() as > > you suggested? > that patch about fixing e820_update_rang is in tip/setup-memory. > > so the one is supposed to be ok, but it is good to keep good input > parameter too. Okay, thanks for review and comments. Patch sent. Bernhard -- Bernhard Walle, SUSE LINUX Products GmbH, Architecture Development -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/