DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=from:to:subject:date:user-agent:cc:references:in-reply-to
         :mime-version:content-type:content-transfer-encoding
         :content-disposition:message-id;
        b=tjGRcPChY6JVsn0AR+GLeq1lx9dSXPrUI3fqIPnS8kGPD4xxvw8itRRTKZeNCEB0rC
         5PbdOxzKksGJGKDXH9d9T+WincAnaWB8DnMsskdcROrrMZ0mnclYo1+EnTjS5xqi1L49
         trv+knseqJf6zbFGUZExhrg0rJPl1wqukHXqc=
From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Adrian Bunk <bunk@kernel.org>
Subject: Re: [0/5] move hd.c to drivers/block/
Date: Wed, 25 Jun 2008 22:16:10 +0200
User-Agent: KMail/1.9.9
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
       rmk@arm.linux.org.uk, Alan Cox <alan@lxorguk.ukuu.org.uk>
References: <20080609222155.GA1987@cs181133002.pp.htv.fi> <200806221521.33506.bzolnier@gmail.com> <20080624215407.GB18252@cs181140183.pp.htv.fi>
In-Reply-To: <20080624215407.GB18252@cs181140183.pp.htv.fi>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200806252216.11112.bzolnier@gmail.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2655
Lines: 54

On Tuesday 24 June 2008, Adrian Bunk wrote:
> On Sun, Jun 22, 2008 at 03:21:33PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > On Sunday 22 June 2008, Adrian Bunk wrote:
> > > On Tue, Jun 10, 2008 at 07:56:15PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > > > On Tuesday 10 June 2008, Adrian Bunk wrote:
> > > > > This patch limits BLK_DEV_HD_ONLY to the ARM platforms offering 
> > > > > IRQ_HARDDISK, fixing the following compile error on others:
> > > > > 
> > > > > <--  snip  -->
> > > > > 
> > > > > ...
> > > > >   CC      drivers/ide/legacy/hd.o
> > > > > ...
> > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c: In function 'hd_times_out':
> > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:542: error: 'IRQ_HARDDISK' undeclared (first use in this function)
> > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:542: error: (Each undeclared identifier is reported only once
> > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:542: error: for each function it appears in.)
> > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c: In function 'do_hd_request':
> > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:661: error: 'IRQ_HARDDISK' undeclared (first use in this function)
> > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c: In function 'hd_init':
> > > > > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/legacy/hd.c:765: error: 'IRQ_HARDDISK' undeclared (first use in this function)
> > > > > make[3]: *** [drivers/ide/legacy/hd.o] Error 1
> > > > > 
> > > > > <--  snip  -->
> > > > > 
> > > > > Reported-by: Adrian Bunk <bunk@kernel.org>
> > > > > Signed-off-by: Adrian Bunk <bunk@kernel.org>
> > > > 
> > > > applied, thanks
> > > > 
> > > > BTW Could you look into converting your "remove BLK_DEV_HD_ONLY" patch
> > > > into "move old hd driver to drivers/block/" one because the old hd driver
> > > > still has some uses (as noticed by Alan)?
> > > 
> > > drivers/ide/Makefile says:
> > >   # old hd driver must be last
> > > 
> > > Is this still true?
> > 
> > Yep.
> > 
> > > If yes then moving the driver to drivers/block/ requires switching to 
> > > late_initcall() since drivers/block/ is linked before drivers/ide/ .
> > 
> > Care to cook a patch?
> 
> Comes as part of this patchset.

thanks, I applied all patches
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/