Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755741AbYFZD61 (ORCPT ); Wed, 25 Jun 2008 23:58:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753306AbYFZD6R (ORCPT ); Wed, 25 Jun 2008 23:58:17 -0400 Received: from vms173001pub.verizon.net ([206.46.173.1]:51357 "EHLO vms173001pub.verizon.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751709AbYFZD6R (ORCPT ); Wed, 25 Jun 2008 23:58:17 -0400 Date: Wed, 25 Jun 2008 23:57:54 -0400 (EDT) From: Len Brown Subject: Re: [PATCH] ACPI: add standard linux WARN() output to ACPI warnings In-reply-to: X-X-Sender: lenb@localhost.localdomain To: Arjan van de Ven Cc: Ingo Molnar , Vegard Nossum , Linux Kernel Mailing List , linux-acpi@vger.kernel.org, Zhao Yakui , "Rafael J. Wysocki" , Alexey Starikovskiy , Yinghai Lu Message-id: MIME-version: 1.0 Content-type: TEXT/PLAIN; charset=US-ASCII References: <20080620095247.GA24557@elte.hu> <20080620135639.GA5073@damson.getinternet.no> <20080620142224.GF8135@elte.hu> <20080624194915.11d6aee9@infradead.org> User-Agent: Alpine 1.10 (LFD 962 2008-03-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 715 Lines: 24 On Tue, 24 Jun 2008, Len Brown wrote: > > > > Please do not use warn_on_slowpath() directly! > > Please use WARN_ON() or WARN(). The later has printk semantics so this > > could turn into > > > > WARN(1, "ACPI Error (%s-%0d): \n", module_name, line_number); > > > > > and kerneloops.org and various other tools will pick up the printk like > > arguments as part of the warning message. > > cool, will do. that is, will do when WARN() actually gets upstream:-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/