Date: Wed, 25 Jun 2008 22:55:50 -0700 (PDT)
Message-Id: <20080625.225550.199765051.davem@davemloft.net>
To: shemminger@vyatta.com
Cc: Jie.Yang@Atheros.com, jeff@garzik.org, linux-kernel@vger.kernel.org,
       netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.25.3 1/5] atl1e: Atheros L1E Gigabit Ethernet driver
From: David Miller <davem@davemloft.net>
In-Reply-To: <20080625224829.3c6f4789@extreme>
References: <72981EBCFD196144B7C6999B9FC34A9A3EE603B863@SHEXMB-01.global.atheros.com>
	<20080625224829.3c6f4789@extreme>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 656
Lines: 16

From: Stephen Hemminger <shemminger@vyatta.com>
Date: Wed, 25 Jun 2008 22:48:29 -0700

> I would prefer that the driver be NAPI only, because configuration
> choices are hard for users and distribution to make correct
> choice. Plus it means two choices for your QA to test.

I agree with Stephen.

It's absolutely to provide a non-NAPI option, please just remove
the option and the conditionals from the code.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/