Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763292AbYFZNMm (ORCPT ); Thu, 26 Jun 2008 09:12:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1762641AbYFZNHE (ORCPT ); Thu, 26 Jun 2008 09:07:04 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:50419 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764675AbYFZNHB (ORCPT ); Thu, 26 Jun 2008 09:07:01 -0400 Date: Thu, 26 Jun 2008 09:07:00 -0400 From: Christoph Hellwig To: Christoph Hellwig , xfs@oss.sgi.com, matthew@wil.cx, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/6] Extend completions to provide XFS object flush requirements Message-ID: <20080626130700.GA24325@infradead.org> References: <1214455277-6387-1-git-send-email-david@fromorbit.com> <1214455277-6387-2-git-send-email-david@fromorbit.com> <20080626074636.GB7064@infradead.org> <20080626112133.GJ11558@disturbed> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080626112133.GJ11558@disturbed> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 633 Lines: 15 On Thu, Jun 26, 2008 at 09:21:33PM +1000, Dave Chinner wrote: > Ok, so that involves exactly what? A new header file, a new API name > (ideas anyone?) and kerneldoc comments? Yes, probably just a new header with properly documented functions. Thew two non-trivial ones you added should probably not be inlines, btw. flush_lock_init/flush_lock/flush_trylock/flush_done/flush_is_locked? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/