Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756872AbYFZPnX (ORCPT ); Thu, 26 Jun 2008 11:43:23 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752976AbYFZPnO (ORCPT ); Thu, 26 Jun 2008 11:43:14 -0400 Received: from moutng.kundenserver.de ([212.227.126.177]:55486 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752774AbYFZPnN convert rfc822-to-8bit (ORCPT ); Thu, 26 Jun 2008 11:43:13 -0400 From: Arnd Bergmann To: monstr@seznam.cz Subject: Re: [PATCH 52/60] microblaze_v4: fcntl.h sockios.h ucontext.h Date: Thu, 26 Jun 2008 17:43:09 +0200 User-Agent: KMail/1.9.9 Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, stephen.neuendorffer@xilinx.com, John.Linn@xilinx.com, john.williams@petalogix.com, matthew@wil.cx, will.newton@gmail.com, drepper@redhat.com, microblaze-uclinux@itee.uq.edu.au, grant.likely@secretlab.ca, linuxppc-dev@ozlabs.org, vapier.adi@gmail.com, alan@lxorguk.ukuu.org.uk, hpa@zytor.com, Michal Simek References: <1214483429-32360-1-git-send-email-monstr@seznam.cz> <1214483429-32360-52-git-send-email-monstr@seznam.cz> <1214483429-32360-53-git-send-email-monstr@seznam.cz> In-Reply-To: <1214483429-32360-53-git-send-email-monstr@seznam.cz> X-Face: I@=L^?./?$U,EK.)V[4*>`zSqm0>65YtkOe>TFD'!aw?7OVv#~5xd\s,[~w]-J!)|%=]>=?utf-8?q?+=0A=09=7EohchhkRGW=3F=7C6=5FqTmkd=5Ft=3FLZC=23Q-=60=2E=60Y=2Ea=5E?= =?utf-8?q?3zb?=) =?utf-8?q?+U-JVN=5DWT=25cw=23=5BYo0=267C=26bL12wWGlZi=0A=09=7EJ=3B=5Cwg?= =?utf-8?q?=3B3zRnz?=,J"CT_)=\H'1/{?SR7GDu?WIopm.HaBG=QYj"NZD_[zrM\Gip^U MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200806261743.10441.arnd@arndb.de> X-Provags-ID: V01U2FsdGVkX18tXG1jvhI9XukhYsqzhzL3pGudDJasYPnc7Ud HCAdwcEKxWXDEzvrTpie6IUwHZC7HrfbgWzycotStyADINklbV lriKiyxywZ+JSsfpxFkdg== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1150 Lines: 25 On Thursday 26 June 2008, monstr@seznam.cz wrote: > ?include/asm-generic/sockios.h ? ? | ? 23 +++++++++++++++++++++++ > ?include/asm-generic/ucontext.h ? ?| ? 24 ++++++++++++++++++++++++ > ?include/asm-microblaze/fcntl.h ? ?| ? ?1 + > ?include/asm-microblaze/sockios.h ?| ? 23 +++++++++++++++++++++++ > ?include/asm-microblaze/ucontext.h | ? ?1 + The grouping of files seems rather arbitrary here. What would be really good here is if you had all the new asm-generic files as separate patches, i.e. as a series adding them independent of the microblaze patches so that the other arch maintainers could look at them and start using the same files, and then add all your trivial wrappers in a single patch. Also, the sockios file here looks like it should be in asm-generic. The contents of the files in this patch all look good, they are identical to the majority of the other architectures. Arnd <>< -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/