Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753437AbYFZRxB (ORCPT ); Thu, 26 Jun 2008 13:53:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752709AbYFZRwu (ORCPT ); Thu, 26 Jun 2008 13:52:50 -0400 Received: from einhorn.in-berlin.de ([192.109.42.8]:59933 "EHLO einhorn.in-berlin.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753219AbYFZRwt (ORCPT ); Thu, 26 Jun 2008 13:52:49 -0400 X-Envelope-From: stefanr@s5r6.in-berlin.de Message-ID: <4863D75F.3000804@s5r6.in-berlin.de> Date: Thu, 26 Jun 2008 19:52:31 +0200 From: Stefan Richter User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.13) Gecko/20080614 SeaMonkey/1.1.9 MIME-Version: 1.0 To: linux1394-devel@lists.sourceforge.net CC: linux-kernel@vger.kernel.org Subject: Re: [PATCH update] firewire: deadline for PHY config transmission References: <4858D304.80907@s5r6.in-berlin.de> In-Reply-To: X-Enigmail-Version: 0.95.6 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 992 Lines: 26 Stefan Richter wrote: > + long timeout = DIV_ROUND_UP(HZ, 10); ... > + card->driver->send_request(card, &p->packet); > + timeout = wait_for_completion_timeout(&p->done, timeout); > + kref_put(&p->kref, phy_packet_release); > > - card->driver->send_request(card, &p.packet); > - wait_for_completion(&p.done); > + /* will leak p if the callback is never executed */ > + WARN_ON(timeout == 0); > } I can easily trigger the WARN_ON with something like "printf 'br short\nbr short\nbr short\n' | firecontrol" (repeatedly done) on an otherwise well behaving FW323. I will eventually look into changing the phy packet submission once more into something which cannot leak memory. -- Stefan Richter -=====-==--- -==- ==-=- http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/