Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759983AbYFZR5P (ORCPT ); Thu, 26 Jun 2008 13:57:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1759867AbYFZR4y (ORCPT ); Thu, 26 Jun 2008 13:56:54 -0400 Received: from adelie.canonical.com ([91.189.90.139]:58081 "EHLO adelie.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759805AbYFZR4x (ORCPT ); Thu, 26 Jun 2008 13:56:53 -0400 Subject: Ambiguous dupe in libusual device list From: Ben Collins To: usb-storage Cc: kernel list Content-Type: text/plain Organization: Canonical Date: Thu, 26 Jun 2008 13:32:36 -0400 Message-Id: <1214501556.7150.36.camel@cunning> Mime-Version: 1.0 X-Mailer: Evolution 2.22.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1313 Lines: 33 In unusual_devs.h, there are these two entries: #ifdef CONFIG_USB_STORAGE_DATAFAB /* Submitted by Olaf Hering */ UNUSUAL_DEV( 0x07c4, 0xa109, 0x0000, 0xffff, "Datafab Systems, Inc.", "USB to CF + SM Combo (LC1)", US_SC_SCSI, US_PR_DATAFAB, NULL, 0 ), #endif #ifdef CONFIG_USB_STORAGE_SDDR55 /* SM part - aeb */ UNUSUAL_DEV( 0x07c4, 0xa109, 0x0000, 0xffff, "Datafab Systems, Inc.", "USB to CF + SM Combo (LC1)", US_SC_SCSI, US_PR_SDDR55, NULL, US_FL_SINGLE_LUN ), #endif If I'm not mistaken (and because libusual is pretty well abstracted, I might be) this is an ambiguous dupe that isn't resolved with any checking (IOW, the second entry is likely never used), at least when both config options are enabled. If that's not the case, then maybe a comment would be in order? If the case is that these two options should not be enabled at the same time, then perhaps some Kconfig magic is required. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/