Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759945AbYFZSUB (ORCPT ); Thu, 26 Jun 2008 14:20:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754127AbYFZSTu (ORCPT ); Thu, 26 Jun 2008 14:19:50 -0400 Received: from py-out-1112.google.com ([64.233.166.179]:12831 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753946AbYFZSTt (ORCPT ); Thu, 26 Jun 2008 14:19:49 -0400 Message-ID: <2c0942db0806260935p51564a7et6517b39e9a6706dc@mail.gmail.com> Date: Thu, 26 Jun 2008 09:35:22 -0700 From: "Ray Lee" To: monstr@seznam.cz Subject: Re: [PATCH 08/60] microblaze_v4: exception handling Cc: linux-kernel@vger.kernel.org, arnd@arndb.de, linux-arch@vger.kernel.org, stephen.neuendorffer@xilinx.com, John.Linn@xilinx.com, john.williams@petalogix.com, matthew@wil.cx, will.newton@gmail.com, drepper@redhat.com, microblaze-uclinux@itee.uq.edu.au, grant.likely@secretlab.ca, linuxppc-dev@ozlabs.org, vapier.adi@gmail.com, alan@lxorguk.ukuu.org.uk, hpa@zytor.com, "Michal Simek" In-Reply-To: <1214483429-32360-9-git-send-email-monstr@seznam.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <1214483429-32360-1-git-send-email-monstr@seznam.cz> <1214483429-32360-2-git-send-email-monstr@seznam.cz> <1214483429-32360-3-git-send-email-monstr@seznam.cz> <1214483429-32360-4-git-send-email-monstr@seznam.cz> <1214483429-32360-5-git-send-email-monstr@seznam.cz> <1214483429-32360-6-git-send-email-monstr@seznam.cz> <1214483429-32360-7-git-send-email-monstr@seznam.cz> <1214483429-32360-8-git-send-email-monstr@seznam.cz> <1214483429-32360-9-git-send-email-monstr@seznam.cz> X-Google-Sender-Auth: 53624df96e3f1392 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 854 Lines: 20 On Thu, Jun 26, 2008 at 5:29 AM, wrote: > +ex_sw: > + /* Get the destination register number into r5 */ > + lbui r5, r0, ex_reg_op; > + /* Form store_word jump table offset (sw_table + (8 * regnum)) */ > + la r6, r0, sw_table; > + add r5, r5, r5; > + add r5, r5, r5; > + add r5, r5, r5; > + add r5, r5, r6; > + bra r5; Possibly stupid question: This is part of the unaligned store word exception handler, yes? Shouldn't the above add's be addk's to preserve the state of the carry register pre/post store? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/