From: Johannes Weiner <hannes@saeurebad.de>
To: Yasunori Goto <y-goto@jp.fujitsu.com>
Cc: Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@elte.hu>,
       Yinghai Lu <yhlu.kernel@gmail.com>, Andi Kleen <andi@firstfloor.org>,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Fix new alloc_bootmem_core (Re: [PATCH -mm 08/14] bootmem: clean up alloc_bootmem_core)
References: <20080605224940.434439989@saeurebad.de>
	<20080605225720.616014665@saeurebad.de>
	<20080617173021.C1FE.E1E9C6FF@jp.fujitsu.com>
Date: Thu, 26 Jun 2008 20:56:52 +0200
In-Reply-To: <20080617173021.C1FE.E1E9C6FF@jp.fujitsu.com> (Yasunori Goto's
	message of "Tue, 17 Jun 2008 18:34:09 +0900")
Message-ID: <87hcbg10uj.fsf@skyscraper.fehenstaub.lan>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 794
Lines: 30

Hi,

Yasunori Goto <y-goto@jp.fujitsu.com> writes:

> Hi Johannes-san.
>
> I found a bug in this patch.
>
>
>> -	eidx = end_pfn - PFN_DOWN(node_boot_start);
>> +	if (goal && goal < max)
>> +		start = ALIGN(goal, step);
>> +	else
>> +		start = ALIGN(min, step);
>
> Here should check (min < goal) too.
>
> If not, start can becomes smaller than min. and sidx doesn't point
> correct index.
> alloc_bootmem_node() almost allocates pages of other node,
> when node's min address is over MAX_DMA_ADDRESS.

Andrew, could you pull that into -mm?

	Hannes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/