Message-ID: <4865160C.2040403@nortel.com>
Date: Fri, 27 Jun 2008 10:32:12 -0600
From: "Chris Friesen" <cfriesen@nortel.com>
User-Agent: Mozilla Thunderbird 1.0.2-6 (X11/20050513)
MIME-Version: 1.0
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
CC: "Maciej W. Rozycki" <macro@linux-mips.org>,
       Cyrill Gorcunov <gorcunov@gmail.com>, Ingo Molnar <mingo@elte.hu>,
       "H. Peter Anvin" <hpa@zytor.com>, Thomas Gleixner <tglx@linutronix.de>,
       LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -tip/master] x86: nmi_watchdog - documentation fix
References: <20080627154340.GC18957@cvg> <Pine.LNX.4.55.0806271652020.8868@cliff.in.clinika.pl> <20080627165937.2f1fb661@lxorguk.ukuu.org.uk>
In-Reply-To: <20080627165937.2f1fb661@lxorguk.ukuu.org.uk>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1011
Lines: 33

Alan Cox wrote:
> On Fri, 27 Jun 2008 16:54:19 +0100 (BST)
> "Maciej W. Rozycki" <macro@linux-mips.org> wrote:
> 
> 
>>On Fri, 27 Jun 2008, Cyrill Gorcunov wrote:
>>
>>
>>>+NOTE: Prior to 2.4.2-ac18 the NMI-oopser is enabled unconditionally
>>>+on x86 SMP boxes.
>>
>> While you are at it: s/is/was/.
> 
> 
> Erm - why ??
> 
> It is still true today that kernels < 2.4.2-ac8 have the NMI oopser
> enabled.

To my ear the phrase as written implies past tense for the author/reader 
(i.e. "at points in time prior to the release of 2.4.2-ac18"), and thus 
grates against "is".

The following sounds better to me: "In kernels prior to 2.4.2-ac18 the 
NMI-oopser is enabled..."  In this context the phrase itself is in the 
present, but we point to past kernels.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/