Message-ID: <48652C7F.1000904@qualcomm.com>
Date: Fri, 27 Jun 2008 11:07:59 -0700
From: Max Krasnyansky <maxk@qualcomm.com>
User-Agent: Thunderbird 2.0.0.14 (X11/20080501)
MIME-Version: 1.0
To: Oleg Nesterov <oleg@tv-sign.ru>
CC: Peter Zijlstra <a.p.zijlstra@chello.nl>, jarkao2@o2.pl,
       linux-kernel@vger.kernel.org
Subject: Re: workqueue flush_work() patches
References: <486525FE.1060509@qualcomm.com> <20080627175633.GA842@tv-sign.ru>
In-Reply-To: <20080627175633.GA842@tv-sign.ru>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1138
Lines: 28

Oleg Nesterov wrote:
> On 06/27, Max Krasnyansky wrote:
>> I'm not sure if you guys saw my last email on this. So I'll restart the 
>> thread.
>> If you guys are ok with the summary I provided below I can put all 
>> Oleg's patches into some git tree, test them on my boxes and resend to 
>> Andrew.
> 
> I'll re-send these flush_work() patches to Andrew on Sunday,
Excellent. Feel free to include
Acked-By: Max Krasnyansky <maxk@qualcomm.com>

>> I was also going to go over the users of flush_queued_work() and 
>> convert them to cancel_work_sync() and/or flush_work().
> 
> I think this would be very nice in any case.
> 
> but I don't think flush_work() will find a lot of users...
Well, you've already found one (schedule_on_each_cpu()) there will 
probably be more. But I agree that flush is mostly used in cleanup 
procedures and therefor most users just need cancel_work_sync().

Max
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/