MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>, Ingo Molnar <mingo@elte.hu>,
       Dmitry Adamushko <dmitry.adamushko@gmail.com>,
       Linus Torvalds <torvalds@linux-foundation.org>,
       Matthew Wilcox <matthew@wil.cx>,
       Peter Zijlstra <a.p.zijlstra@chello.nl>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] sched: fix TASK_WAKEKILL vs SIGKILL race
In-Reply-To: Oleg Nesterov's message of  Sunday, 8 June 2008 21:20:41 +0400 <20080608172041.GA10383@tv-sign.ru>
References: <20080608172041.GA10383@tv-sign.ru>
Emacs: impress your (remaining) friends and neighbors.
Message-Id: <20080627204954.4CC04154226@magilla.localdomain>
Date: Mon,  9 Jun 2008 14:10:50 -0700 (PDT)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 784
Lines: 20

I was also concerned about perturbing the schedule() hot path with the
original patch.  With this version making signal_pending_state() inline,
I think it's good.

> Note this "__TASK_STOPPED | __TASK_TRACED" check in signal_pending_state().
> This is needed to preserve the current behaviour (ptrace_notify). I hope
> this check will be removed soon, but this (afaics good) change needs the
> separate discussion.

Agreed.  I think it might actually already be safe to drop it, but we can
get to that after this settles.


Thanks,
Roland
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/