Message-ID: <48657636.8070208@kernel.org>
Date: Fri, 27 Jun 2008 16:22:30 -0700
From: "H. Peter Anvin" <hpa@kernel.org>
Organization: Linux Kernel Organization, Inc.
User-Agent: Thunderbird 2.0.0.14 (X11/20080501)
MIME-Version: 1.0
To: Glauber Costa <gcosta@redhat.com>
CC: linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@elte.hu,
       x86@kernel.org
Subject: Re: [PATCH 08/39] don't use word-size specifiers
References: <1214602486-17080-1-git-send-email-gcosta@redhat.com> <1214602486-17080-2-git-send-email-gcosta@redhat.com> <1214602486-17080-3-git-send-email-gcosta@redhat.com> <1214602486-17080-4-git-send-email-gcosta@redhat.com> <1214602486-17080-5-git-send-email-gcosta@redhat.com> <1214602486-17080-6-git-send-email-gcosta@redhat.com> <1214602486-17080-7-git-send-email-gcosta@redhat.com> <1214602486-17080-8-git-send-email-gcosta@redhat.com> <1214602486-17080-9-git-send-email-gcosta@redhat.com> <48657524.4020307@kernel.org>
In-Reply-To: <48657524.4020307@kernel.org>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1301
Lines: 28

H. Peter Anvin wrote:
> 
> I hate to say it, but I really think this is a step backwards in 
> readability.  Consistency is a good thing, and with the suffixes in 
> place we are consistent between instructions that refer to memory and 
> instructions that refer to registers.  We also get one more check on 
> things, where the assembler can tell the programmer he probably typoed.
> 
> So I would prefer if we *didn't* go down this route, except for explicit 
> unification, but that's not the case here (since the size is still 
> explicit in the register names.)
> 

Okay, I didn't really explain what I meant very well here...

Obviously, most of your patch series is all about unification, and that 
is a Good Thing, and thank you for doing it.  What I was trying to say 
was that it is not obvious from just reading the patchset what changes 
are necessary for unification, and which one are a stylistic change.  If 
*all* the changes are unification, please just say so and disregard this 
remark, and I'll go ahead and apply your patchset.

	-hpa
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/