Date: Sat, 28 Jun 2008 16:41:46 +0200
From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: Pierre Ossman <drzeus-mmc@drzeus.cx>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mmc: Export internal host state through debugfs
Message-ID: <20080628164146.094a2c82@hskinnemo-gx745.norway.atmel.com>
In-Reply-To: <20080628162312.0f10c6d3@hskinnemo-gx745.norway.atmel.com>
References: <1214478589-21291-1-git-send-email-haavard.skinnemoen@atmel.com>
	<20080628152856.3ba1c2ff@mjolnir.drzeus.cx>
	<20080628153704.36eda3e6@hskinnemo-gx745.norway.atmel.com>
	<20080628154015.423daf51@mjolnir.drzeus.cx>
	<20080628162312.0f10c6d3@hskinnemo-gx745.norway.atmel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 805
Lines: 18

Haavard Skinnemoen <haavard.skinnemoen@atmel.com> wrote:
> Actually, if debugfs is disabled, debugfs_create_dir() and friends are
> inline functions which return ERR_PTR(-ENODEV). So if we just remove
> the whole #ifdef altogether, gcc should be smart enough to optimize
> away the whole thing if debugfs isn't enabled...
> 
> I'll give it a try.

Yeah, it does seem to work, but it means we'll have to put at least
debugfs_root into struct mmc_host unconditionally. Assuming we find a
way to not put all the other stuff in there, is that acceptable?

Haavard
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/