Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758149AbYF1OwB (ORCPT ); Sat, 28 Jun 2008 10:52:01 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753497AbYF1Ovw (ORCPT ); Sat, 28 Jun 2008 10:51:52 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:38720 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751256AbYF1Ovv (ORCPT ); Sat, 28 Jun 2008 10:51:51 -0400 Date: Sat, 28 Jun 2008 16:51:13 +0200 From: Ingo Molnar To: Jaswinder Singh Cc: "Rafael J. Wysocki" , David Woodhouse , Stephen Rothwell , linux-next@vger.kernel.org, LKML , Andrew Morton , kernel-testers@vger.kernel.org, "Maciej W. Rozycki" Subject: Re: linux-next: Tree for June 26 Message-ID: <20080628145113.GA26878@elte.hu> References: <20080627010842.e1a0c4b5.sfr@canb.auug.org.au> <200806270138.53895.rjw@sisk.pl> <1214563913.10393.180.camel@pmac.infradead.org> <200806280104.17527.rjw@sisk.pl> <1214646863.2660.22.camel@jaswinder.satnam> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1214646863.2660.22.camel@jaswinder.satnam> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1142 Lines: 32 * Jaswinder Singh wrote: > No, firmware is same. > > Our Firmware blob looks like this... > u8 firmware_major > u8 firmware_minor > u8 firmware_fix > u8 pad > __be32 start_address > __be32 length (total, including BSS sections to be zeroed) > data... (in __be32 words, which is native for the firmware) > > rest of data is same and you can see it manually. > > I am surprise why Ingo is using hex dump and he finds different data. > > And I did not received any feedback from Ingo yet. sorry - it was just a drive-by comment i made to Rafael while i reacted to the x86 portion of his mail - i dont have this tg3 problem myself so there's nothing i could report or test. I only looked at the patch that was identified and the tg3FwText[] array appeared to be different - but as you explain it above, that is OK and the firmware image is the same. Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/