Date: Sat, 28 Jun 2008 18:11:45 +0200
From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mmc: Add per-card debugfs support
Message-ID: <20080628181145.60c55ea0@mjolnir.drzeus.cx>
In-Reply-To: <20080628173637.53e3279f@hskinnemo-gx745.norway.atmel.com>
References: <1214478589-21291-1-git-send-email-haavard.skinnemoen@atmel.com>
	<1214478589-21291-2-git-send-email-haavard.skinnemoen@atmel.com>
	<1214478589-21291-3-git-send-email-haavard.skinnemoen@atmel.com>
	<20080628153745.027b0817@mjolnir.drzeus.cx>
	<20080628154844.35a90ae9@hskinnemo-gx745.norway.atmel.com>
	<20080628160110.41ec91f7@mjolnir.drzeus.cx>
	<20080628161524.5c3fd45f@hskinnemo-gx745.norway.atmel.com>
	<20080628172205.430b35b2@mjolnir.drzeus.cx>
	<20080628173637.53e3279f@hskinnemo-gx745.norway.atmel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1285
Lines: 34

On Sat, 28 Jun 2008 17:36:37 +0200
Haavard Skinnemoen <haavard.skinnemoen@atmel.com> wrote:

> Pierre Ossman <drzeus-mmc@drzeus.cx> wrote:
> > 
> > An alternative to sticking it into mmc.c is to create a debugfs.c that
> > contains all the uglyness. Debugging code isn't quite as important to
> > keep crystal clear.
> 
> But if we're going to rely on gcc optimizing the whole thing away when
> debugfs is disabled, we must keep these buggers in the same file as its
> caller...
> 
> Though I suppose an extra function call that does nothing at host and
> card registration time isn't a very high price to pay for cleaner code.
> 

This is in the device addition/removal code as well. Hardly a hotpath.

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/