Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758020AbYF1RyU (ORCPT ); Sat, 28 Jun 2008 13:54:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753389AbYF1RyK (ORCPT ); Sat, 28 Jun 2008 13:54:10 -0400 Received: from mta23.gyao.ne.jp ([125.63.38.249]:36366 "EHLO mx.gate01.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753388AbYF1RyJ (ORCPT ); Sat, 28 Jun 2008 13:54:09 -0400 Date: Sun, 29 Jun 2008 02:51:33 +0900 From: Paul Mundt To: Johannes Weiner Cc: Andrew Morton , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org Subject: Re: [PATCH 02/20] mm: generic show_mem() Message-ID: <20080628175133.GA6364@linux-sh.org> Mail-Followup-To: Paul Mundt , Johannes Weiner , Andrew Morton , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org References: <20080627115349.743368154@saeurebad.de> <20080627120048.059732179@saeurebad.de> <20080628042240.GB25492@linux-sh.org> <87myl5ama2.fsf@skyscraper.fehenstaub.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87myl5ama2.fsf@skyscraper.fehenstaub.lan> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1393 Lines: 28 On Sat, Jun 28, 2008 at 12:25:57PM +0200, Johannes Weiner wrote: > Paul Mundt writes: > > On Fri, Jun 27, 2008 at 01:53:51PM +0200, Johannes Weiner wrote: > >> This implements a platform-independent version of show_mem(). > >> > >> Signed-off-by: Johannes Weiner > > > > Looking at this again, does having this as a Kconfig option really make > > sense? We have no tristate in-tree users of this that I can see, wouldn't > > this be better off in lib/? It would be preferable not to let the > > HAVE_foo stuff get out of hand if we can avoid it. > > I hate the current Kconfig usage, too. But I figured, if I won't obey > on such decisions by people who maintain it, it won't have a chance to > get in. > > So, what do you suggest? Moving it to lib/ and have one simple #define > if the arch wants to use it or not? > There's no need for a define. If you move it to lib/ it will just be the default implementation unless an architecture overloads it with their own definition. With your current patch set, you should just be able to shove it in to lib/, drop the Kconfig option, and be good to go. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/