Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753366AbYF1T5W (ORCPT ); Sat, 28 Jun 2008 15:57:22 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751181AbYF1T5M (ORCPT ); Sat, 28 Jun 2008 15:57:12 -0400 Received: from 136-022.dsl.labridge.com ([206.117.136.22]:1524 "EHLO mail.perches.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1750928AbYF1T5K (ORCPT ); Sat, 28 Jun 2008 15:57:10 -0400 Subject: Re: [patch 11/28] PNP: whitespace/coding style fixes From: Joe Perches To: Bjorn Helgaas Cc: Len Brown , Andi Kleen , linux-acpi@vger.kernel.org, Rene Herman , linux-kernel@vger.kernel.org, Adam Belay , Adam M Belay , Li Shaohua , Matthieu Castet , Thomas Renninger , Rene Herman , Jaroslav Kysela , Andrew Morton , Takashi Iwai , Jiri Slaby , David Howells , Bartlomiej Zolnierkiewicz In-Reply-To: <20080627225800.517972351@ldl.fc.hp.com> References: <20080627225651.663174474@ldl.fc.hp.com> <20080627225800.517972351@ldl.fc.hp.com> Content-Type: text/plain Date: Sat, 28 Jun 2008 12:56:23 -0700 Message-Id: <1214682983.8758.66.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.12.3-1.3mdv2008.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1189 Lines: 29 On Fri, 2008-06-27 at 16:57 -0600, Bjorn Helgaas wrote: > Index: work10/drivers/pnp/interface.c > =================================================================== > --- work10.orig/drivers/pnp/interface.c 2008-05-09 14:42:25.000000000 -0600 > +++ work10/drivers/pnp/interface.c 2008-05-09 14:45:57.000000000 -0600 > @@ -216,12 +216,12 @@ static ssize_t pnp_show_options(struct d > struct device_attribute *attr, char *buf) > { > struct pnp_dev *dev = to_pnp_dev(dmdev); > + pnp_info_buffer_t *buffer; > struct pnp_option *independent = dev->independent; > struct pnp_option *dependent = dev->dependent; > int ret, dep = 1; > > - pnp_info_buffer_t *buffer = (pnp_info_buffer_t *) > - pnp_alloc(sizeof(pnp_info_buffer_t)); > + buffer = pnp_alloc(sizeof(pnp_info_buffer_t)); > if (!buffer) > return -ENOMEM; Wouldn't it be nicer without the unnecessary cast? pnp_info_buffer_t *buffer = pnp_alloc(sizeof(*buffer)); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/