DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=seznam.cz;
	h=In-Reply-To:Received:Date:Cc:To:From:Subject:Mime-Version:Message-Id:Content-Transfer-Encoding:Content-Type:X-Abuse:X-Seznam-User:X-QM-Mark;
	b=Nnfs/flS3Ir96Me9Ba9rmcIbDrBev79sCI7qLTF+yqp587fmkfUOuJ+tNFgo8cp6n
	mwxB+UusyKqCkr1F3YLme+W/RiPbG2tPY5a+f1qIqvSLBDDf+aVxpL7VUB5AHc9N63/
	zg7JNYaErrKPbqeDOw5BERloEXWYbvENee8zMhM=
In-Reply-To: <6e8c2b4453be89dba35e0595c9cfcf0a@kernel.crashing.org>
Date: Mon, 30 Jun 2008 09:18:10 +0200 (CEST)
Cc: hpa@zytor.com, John.Linn@xilinx.com, arnd@arndb.de, drepper@redhat.com,
       matthew@wil.cx, john.williams@petalogix.com,
       linux-kernel@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
       linuxppc-dev@ozlabs.org,
       =?us-ascii?Q?Michal=20Simek?= <monstr@monstr.eu>, vapier.adi@gmail.com,
       microblaze-uclinux@itee.uq.edu.au, linux-arch@vger.kernel.org,
       will.newton@gmail.com
To: =?us-ascii?Q?Segher=20Boessenkool?= <segher@kernel.crashing.org>
From: =?us-ascii?Q?Michal=20Simek?= <Monstr@seznam.cz>
Subject: =?us-ascii?Q?Re=3A=20=5BPATCH=2019=2F60=5D=20microblaze=5Fv4=3A=20checksum=20support?=
Mime-Version: 1.0
Message-Id: <4117.6640-711-1819091302-1214810290@seznam.cz>
Content-Transfer-Encoding: 7bit
Content-Type: text/plain;
	charset="us-ascii";
	format=flowed
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1000
Lines: 36

Hi Segher,

you find bug because there is microblaze asm code in generic folder. 
Big thanks. I'll fix it and I'll look at parameters too.

Michal

> +static inline unsigned int
> +csum_tcpudp_nofold(unsigned long saddr, unsigned long daddr, unsigned 
> short len,
> +		unsigned short proto, unsigned int sum)
> +{
> +	__asm__("add %0, %4, %1\n\t"
> +		"addc %0, %4, %2\n\t"
> +		"addc %0, %4, %3\n\t"
> +		"addc %0, %4, r0\n\t"
> +		: "=d" (sum)
> +		: "d" (saddr), "d" (daddr), "d" (len + proto),
> +		"0"(sum));

"sum" should use an earlyclobber, i.e.  "=&d"(sum)  , since some
inputs are used after %0 is first written to.

Also, you can use "+" instead of "=" to say the argument is both
input and output, and get rid of %4, if you like.


Segher


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/