Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759615AbYF3KX4 (ORCPT ); Mon, 30 Jun 2008 06:23:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755364AbYF3KXs (ORCPT ); Mon, 30 Jun 2008 06:23:48 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:39377 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754920AbYF3KXr (ORCPT ); Mon, 30 Jun 2008 06:23:47 -0400 Date: Mon, 30 Jun 2008 12:23:32 +0200 From: Ingo Molnar To: Matti Linnanvuori Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, linux-kernel@vger.kernel.org Subject: Re: [patch] x86: add compilation checks to pci_unmap_ macros Message-ID: <20080630102332.GC31497@elte.hu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1474 Lines: 35 * Matti Linnanvuori wrote: > From: Matti Linnanvuori > > Add compilation checks to pci_unmap_ macros. > -#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME) > -#define DECLARE_PCI_UNMAP_LEN(LEN_NAME) > -#define pci_unmap_addr(PTR, ADDR_NAME) (0) > -#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL) do { } while (0) > -#define pci_unmap_len(PTR, LEN_NAME) (0) > -#define pci_unmap_len_set(PTR, LEN_NAME, VAL) do { } while (0) > +#define DECLARE_PCI_UNMAP_ADDR(ADDR_NAME) dma_addr_t ADDR_NAME[0]; > +#define DECLARE_PCI_UNMAP_LEN(LEN_NAME) unsigned LEN_NAME[0]; > +#define pci_unmap_addr(PTR, ADDR_NAME) sizeof((PTR)->ADDR_NAME) > +#define pci_unmap_addr_set(PTR, ADDR_NAME, VAL) \ > + do { break; } while (pci_unmap_addr(PTR, ADDR_NAME)) > +#define pci_unmap_len(PTR, LEN_NAME) sizeof((PTR)->LEN_NAME) > +#define pci_unmap_len_set(PTR, LEN_NAME, VAL) \ > + do { break; } while (pci_unmap_len(PTR, LEN_NAME)) applied to tip/x86/cleanups - thanks Matti. Would you be interested in doing a small cleanup as well and convert the parameter names to non-shouting lower-case letters? (If you do it then please do it as a delta patch as i've already applied your current patch.) Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/