Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763080AbYF3NVu (ORCPT ); Mon, 30 Jun 2008 09:21:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932075AbYF3NVQ (ORCPT ); Mon, 30 Jun 2008 09:21:16 -0400 Received: from mx1.redhat.com ([66.187.233.31]:41867 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762974AbYF3NVO (ORCPT ); Mon, 30 Jun 2008 09:21:14 -0400 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <48635799.3010500@kernel.org> References: <48635799.3010500@kernel.org> To: "Andrew G. Morgan" Cc: dhowells@redhat.com, Andrew Morton , "Serge E. Hallyn" , lkml , Linux Security Modules List Subject: Re: [PATCH 1/4] security: filesystem capabilities bugfix1 X-Mailer: MH-E 8.0.3+cvs; nmh 1.3; GNU Emacs 23.0.50 Date: Mon, 30 Jun 2008 14:15:11 +0100 Message-ID: <29651.1214831711@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 806 Lines: 20 Andrew G. Morgan wrote: > +kernel_cap_t cap_set_effective(const kernel_cap_t pE_new) Hmmm... kernel_cap_t is a structure that might not fit into a single register. It occurs to me that you might be better off returing the old caps through a pointer argument. It should still work, though. The SElinux and syscalls LTP testscripts work okay for these patches when ported to linux-next. The filecaps LTP testscript can't be used on Fedora 9 as the setcap command is used incorrectly. Acked-by: David Howells David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/