Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752886AbYF3OzV (ORCPT ); Mon, 30 Jun 2008 10:55:21 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758834AbYF3Oyn (ORCPT ); Mon, 30 Jun 2008 10:54:43 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:60397 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758666AbYF3Oym (ORCPT ); Mon, 30 Jun 2008 10:54:42 -0400 Subject: Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM driver to request_firmware() From: David Woodhouse To: "Chas Williams (CONTRACTOR)" Cc: netdev@vger.kernel.org, linux-atm-general@lists.sourceforge.net, linux-kernel@vger.kernel.org In-Reply-To: <200806301359.m5UDxcjJ023252@cmf.nrl.navy.mil> References: <200806301359.m5UDxcjJ023252@cmf.nrl.navy.mil> Content-Type: text/plain Date: Mon, 30 Jun 2008 15:54:38 +0100 Message-Id: <1214837678.10393.345.camel@pmac.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1081 Lines: 28 On Mon, 2008-06-30 at 09:59 -0400, Chas Williams (CONTRACTOR) wrote: > In message <1214832072.10393.342.camel@pmac.infradead.org>,David Woodhouse writ > es: > >On Mon, 2008-06-30 at 09:15 -0400, Chas Williams (CONTRACTOR) wrote: > >> In message <1214831362.10393.340.camel@pmac.infradead.org>,David Woodhouse w > >rit > >> es: > >> >And wasn't it sba200e_ecd.bin ? > >> > >> oops. sparc is big endian. adding the const we have... > > > >You probably still want the ifdefs for MODULE_FIRMWARE(). > > i removed the #ifdef's from around MODULE_LICENSE(). there shouldnt > be any need for #ifdef's around MODULE_FIRMWARE() either. Unless you put #ifdef CONFIG_SBUS around the MODULE_FIRMWARE("sba200e_ecd.bin") you will be requesting that firmware even on non-sbus machines. Likewise little-endian vs. big-endian on PCI. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/