Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761936AbYF3RUF (ORCPT ); Mon, 30 Jun 2008 13:20:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753244AbYF3RTx (ORCPT ); Mon, 30 Jun 2008 13:19:53 -0400 Received: from mail.vyatta.com ([216.93.170.194]:54344 "EHLO mail.vyatta.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751733AbYF3RTw (ORCPT ); Mon, 30 Jun 2008 13:19:52 -0400 X-Spam-Flag: NO X-Spam-Score: -1.639 Date: Mon, 30 Jun 2008 10:19:48 -0700 From: Stephen Hemminger To: Krzysztof Halasa Cc: Jeff Garzik , Andrew Morton , , lkml Subject: Re: [PATCH] Add missing skb->dev assignment in Frame Relay RX code Message-ID: <20080630101948.535496a9@extreme> In-Reply-To: References: <20080629130420.62d00d59@extreme> Organization: Vyatta X-Mailer: Claws Mail 3.3.1 (GTK+ 2.12.9; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1959 Lines: 51 On Sun, 29 Jun 2008 23:10:11 +0200 Krzysztof Halasa wrote: > Stephen Hemminger writes: > > >> --- a/drivers/net/wan/hdlc_fr.c > >> +++ b/drivers/net/wan/hdlc_fr.c > >> @@ -1008,6 +1008,7 @@ static int fr_rx(struct sk_buff *skb) > >> stats->rx_bytes += skb->len; > >> if (pvc->state.becn) > >> stats->rx_compressed++; > >> + skb->dev = dev; > >> netif_rx(skb); > >> return NET_RX_SUCCESS; > >> } else { > > > > Better to use netdev_alloc_skb for receive buffers instead. > > --- a/drivers/net/wan/hdlc_fr.c 2008-06-29 13:02:42.000000000 -0700 > > +++ b/drivers/net/wan/hdlc_fr.c 2008-06-29 13:04:01.000000000 -0700 > > @@ -515,7 +515,7 @@ static void fr_lmi_send(struct net_devic > > } > > } > > > > - skb = dev_alloc_skb(len); > > + skb = netdev_alloc_skb(dev, len); > > if (!skb) { > > printk(KERN_WARNING "%s: Memory squeeze on fr_lmi_send()\n", > > dev->name); > > Well, no, that's another story - the missing assignment is in fr_rx(), > in the regular receive path (similar to 802.1q case, ethX -> > ethX.VLAN_ID transition). I.e., we get incoming packet from a hardware > driver, with skb->dev pointing to hardware hdlcX device, and we change > it to point to a logical pvcX device. > > fr_lmi_send() is for control messages (generated locally) only, in TX > path. IOW we alloc skb and send it through hw driver immediately. Not > related to the bug. > > That said, perhaps I should indeed use netdev_alloc_skb() for those > control messages? Or is it RX-only? netdev_alloc_skb does two things: 1) it sets skb->dev 2) on some platforms it can choose memory "closer" to the device. but this is really a NUMA issue -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/