Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764175AbYF3Tfi (ORCPT ); Mon, 30 Jun 2008 15:35:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753241AbYF3Tf1 (ORCPT ); Mon, 30 Jun 2008 15:35:27 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:42814 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1751673AbYF3Tf0 (ORCPT ); Mon, 30 Jun 2008 15:35:26 -0400 Date: Mon, 30 Jun 2008 15:35:25 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Stefan Becker cc: David Brownell , , , ext Linus Torvalds Subject: Re: [PATCH] USB: fix interrupt disabling for HCDs with shared interrupt handlers In-Reply-To: <48692B9C.7090608@nokia.com> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 23 On Mon, 30 Jun 2008, Stefan Becker wrote: > Hi, > > here is the proposed patch to fix the problem. I hope I used git > correctly to generate it... > This patch doesn't modify the interface of usb_add_hcd(), i.e. HCD code > can still use IRQF_DISABLED. It will now silently convert this into an > internal HCD flag and clear IRQF_DISABLED before requesting the interrupt > from the Linux core. usb_hcd_irq() will check this flag to disable/re-enable > the interrupts on a case by case basis. Don't bother with this extra stuff. All USB host controller drivers want to have interrupts disabled when their IRQ handlers run. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/