Date: Mon, 30 Jun 2008 12:46:41 -0700 (PDT)
Message-Id: <20080630.124641.13641106.davem@davemloft.net>
To: chas@cmf.nrl.navy.mil
Cc: dwmw2@infradead.org, netdev@vger.kernel.org,
       linux-atm-general@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [Linux-ATM-General] [PATCH] firmware: convert Ambassador ATM
 driver to request_firmware()
From: David Miller <davem@davemloft.net>
In-Reply-To: <200806301610.m5UGAlqr025302@cmf.nrl.navy.mil>
References: <1214837678.10393.345.camel@pmac.infradead.org>
	<200806301610.m5UGAlqr025302@cmf.nrl.navy.mil>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1053
Lines: 23

From: "Chas Williams (CONTRACTOR)" <chas@cmf.nrl.navy.mil>
Date: Mon, 30 Jun 2008 12:10:47 -0400

> In message <1214837678.10393.345.camel@pmac.infradead.org>,David Woodhouse writ
> es:
> >> i removed the #ifdef's from around MODULE_LICENSE().  there shouldnt
> >> be any need for #ifdef's around MODULE_FIRMWARE() either.
> >
> >Unless you put #ifdef CONFIG_SBUS around the
> >MODULE_FIRMWARE("sba200e_ecd.bin") you will be requesting that firmware
> >even on non-sbus machines. Likewise little-endian vs. big-endian on PCI.
> 
> does it?  i was under the impression that MODULE_FIRMWARE() just
> provides a hint that modinfo can read.  request_firmware() still
> the requestor for the firmware image.

And also, there are systems with both PCI and SBUS so we should
make sure we handle that properly here.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/