Date: Tue, 1 Jul 2008 10:17:35 +0300
From: Adrian Bunk <bunk@kernel.org>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: -Wmissing-prototypes (was: make foo() static)
Message-ID: <20080701071735.GA17047@cs181140183.pp.htv.fi>
References: <20080630221918.GI1536@cs181140183.pp.htv.fi> <4869D1F3.3030804@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <4869D1F3.3030804@redhat.com>
User-Agent: Mutt/1.5.18 (2008-05-17)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1100
Lines: 33

On Tue, Jul 01, 2008 at 08:42:59AM +0200, Gerd Hoffmann wrote:
> Adrian Bunk wrote:
> 
> > This patch makes the needlessly global kvm_smp_prepare_boot_cpu() static.
> 
> Hmm, maybe we should build the kernel with -Wmissing-prototypes?
> That should make gcc print a warning for that ...

I started 3 or 4 years ago cleaning up the kernel for 
-Wmissing-prototypes and I'm still working on it.

Many parts of the kernel now compile cleanly or nearly cleanly, but 
looking at e.g. arch/ I know what kind of answers I would get if 
suggesting adding -Wmissing-prototypes today...

> cheers,
>   Gerd

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/