Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755847AbYGAHU6 (ORCPT ); Tue, 1 Jul 2008 03:20:58 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755400AbYGAHUo (ORCPT ); Tue, 1 Jul 2008 03:20:44 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:44048 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755300AbYGAHUn (ORCPT ); Tue, 1 Jul 2008 03:20:43 -0400 Date: Tue, 1 Jul 2008 09:20:24 +0200 From: Ingo Molnar To: "Rafael J. Wysocki" Cc: kernel-testers@vger.kernel.org, ACPI Devel Maling List , Andi Kleen , LKML , pm list , "H. Peter Anvin" , Pavel Machek , Linus Torvalds , Andrew Morton Subject: Re: [RFT] x86 acpi: normalize segment descriptor register on resume Message-ID: <20080701072024.GB26601@elte.hu> References: <200807010148.02135.rjw@sisk.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200807010148.02135.rjw@sisk.pl> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 37 * Rafael J. Wysocki wrote: > Hi, > > The appended patch fixes a regression and is considered as 2.6.26 > material. Everyone having a box with working suspend to RAM is gently > requested to test it and verify if it doesn't break things. > > The patch applies to the current -git. The fix is _really_ tempting, but i think it's 2.6.26.1 material at the earliest. I just counted about 8 red flag items in that commit: - "assembly code" - "fresh change" - "suspend/resume" - "real-mode code" - "ACPI" - "SMM" - "CPU erratas" - "boot code" I'd say it's probably 90% fine, but it's just too much risk at this stage i think. The regression was only found 2 weeks ago, and the commit that broke it was upstream for 2 months (and was under testing for about 4 months). [ We have to try to shorten the test cycle for such problems. Hopefully in v2.6.27 we'll have CONFIG_PM_TEST_SUSPEND=y :-) ] Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/