Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755972AbYGAHa1 (ORCPT ); Tue, 1 Jul 2008 03:30:27 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753353AbYGAHaL (ORCPT ); Tue, 1 Jul 2008 03:30:11 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:41203 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752284AbYGAHaK (ORCPT ); Tue, 1 Jul 2008 03:30:10 -0400 Date: Tue, 1 Jul 2008 00:28:56 -0700 From: Andrew Morton To: Ingo Molnar Cc: "Rafael J. Wysocki" , kernel-testers@vger.kernel.org, ACPI Devel Maling List , Andi Kleen , LKML , pm list , "H. Peter Anvin" , Pavel Machek , Linus Torvalds , stable@kernel.org Subject: Re: [RFT] x86 acpi: normalize segment descriptor register on resume Message-Id: <20080701002856.2457a75d.akpm@linux-foundation.org> In-Reply-To: <20080701072024.GB26601@elte.hu> References: <200807010148.02135.rjw@sisk.pl> <20080701072024.GB26601@elte.hu> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1407 Lines: 39 On Tue, 1 Jul 2008 09:20:24 +0200 Ingo Molnar wrote: > * Rafael J. Wysocki wrote: > > > Hi, > > > > The appended patch fixes a regression and is considered as 2.6.26 > > material. Everyone having a box with working suspend to RAM is gently > > requested to test it and verify if it doesn't break things. > > > > The patch applies to the current -git. > > The fix is _really_ tempting, but i think it's 2.6.26.1 material at the > earliest. I just counted about 8 red flag items in that commit: > > - "assembly code" > - "fresh change" > - "suspend/resume" > - "real-mode code" > - "ACPI" > - "SMM" > - "CPU erratas" > - "boot code" > > I'd say it's probably 90% fine, but it's just too much risk at this > stage i think. The regression was only found 2 weeks ago, and the commit > that broke it was upstream for 2 months (and was under testing for about > 4 months). Merge it into 2.6.27-rc1 and add Cc: to the changelog with a note "needed in 2.6.26.x after a couple of weeks testing in mainline" or something like that. I expect 2.6.25.x will be maintained for a while yet too... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/