Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755529AbYGAHb4 (ORCPT ); Tue, 1 Jul 2008 03:31:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751331AbYGAHbr (ORCPT ); Tue, 1 Jul 2008 03:31:47 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:38234 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751156AbYGAHbq (ORCPT ); Tue, 1 Jul 2008 03:31:46 -0400 Date: Tue, 1 Jul 2008 03:31:42 -0400 From: Christoph Hellwig To: Denys Vlasenko Cc: Andrew Morton , Al Viro , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] (resend) reuse xxx_fifo_fops for xxx_pipe_fops Message-ID: <20080701073142.GA30362@infradead.org> References: <200807011103.02974.vda.linux@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200807011103.02974.vda.linux@googlemail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 712 Lines: 19 On Tue, Jul 01, 2008 at 11:03:02AM +0200, Denys Vlasenko wrote: > Hi Andrew, Al, > > I posted this patch a few months ago, but it apparently > fell thru cracks. Here we go again. > > I noticed that read/write/rdwr_pipe_fops are (1) const and > (2) exactly identical to xxx_fifo_fops, which are also const. > > Attached patch #defines xxx_pipe_fops as aliases to xxx_fifo_fops. > Size difference: Why do you need the #defines? Just use the _fifo_ name directly. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/