Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756267AbYGAIHj (ORCPT ); Tue, 1 Jul 2008 04:07:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753599AbYGAIH0 (ORCPT ); Tue, 1 Jul 2008 04:07:26 -0400 Received: from pasmtpb.tele.dk ([80.160.77.98]:34364 "EHLO pasmtpB.tele.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753005AbYGAIHY (ORCPT ); Tue, 1 Jul 2008 04:07:24 -0400 Date: Tue, 1 Jul 2008 10:08:11 +0200 From: Sam Ravnborg To: Ingo Molnar Cc: kbuild , lkml , Roman Zippel Subject: Re: [PATCH 21/24] kconfig: prefix hex values with 0x in .config Message-ID: <20080701080811.GA5807@uranus.ravnborg.org> References: <20080630213155.GA32479@uranus.ravnborg.org> <1214861718-32626-21-git-send-email-sam@ravnborg.org> <20080701064122.GE16642@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080701064122.GE16642@elte.hu> User-Agent: Mutt/1.4.2.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1633 Lines: 44 On Tue, Jul 01, 2008 at 08:41:22AM +0200, Ingo Molnar wrote: > > * Sam Ravnborg wrote: > > > We could hit a situation where hex values > > are stored internally in kconfig without 0x prefix, so if we see > > one of these add 0x prefix when we write value to .config. > > The real fix is to make sure we always prefix hex > > values with 0x in kconfig. > > > > Signed-off-by: Sam Ravnborg > > Cc: Roman Zippel > > --- > > arch/x86/boot/compressed/relocs.c | 2 +- > > scripts/kconfig/confdata.c | 2 +- > > 2 files changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/arch/x86/boot/compressed/relocs.c b/arch/x86/boot/compressed/relocs.c > > index edaadea..88d27f6 100644 > > --- a/arch/x86/boot/compressed/relocs.c > > +++ b/arch/x86/boot/compressed/relocs.c > > @@ -244,7 +244,7 @@ static void read_ehdr(FILE *fp) > > static void read_shdrs(FILE *fp) > > { > > int i; > > - if (ehdr.e_shnum > MAX_SHDRS) { > > + if (1 || ehdr.e_shnum > MAX_SHDRS) { > > die("%d section headers supported: %d\n", > > ehdr.e_shnum, MAX_SHDRS); > > } > > note: stale x86 change slipped into this patch, please do not commit it > to the kbuild tree. (i suspect it happened when you sent me the > MAX_SHDRS debug patch yesterday) Crap - thanks for noticing. I will rebase tonight when I get home. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/