From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Christoph Hellwig <hch@infradead.org>
Cc: akpm@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/7] fat: Fix VFAT_IOCTL_READDIR_xxx and cleanup for userland
References: <9edbdefc3e848699cfe111608.ps@mail.parknet.co.jp>
	<129170883e848699cff211608.ps@mail.parknet.co.jp>
	<20080701074033.GB30362@infradead.org>
Date: Tue, 01 Jul 2008 17:33:36 +0900
In-Reply-To: <20080701074033.GB30362@infradead.org> (Christoph Hellwig's
	message of "Tue, 1 Jul 2008 03:40:33 -0400")
Message-ID: <87zlp2uhpb.fsf@devron.myhome.or.jp>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1243
Lines: 27

Christoph Hellwig <hch@infradead.org> writes:

> On Tue, Jul 01, 2008 at 11:57:03AM +0900, OGAWA Hirofumi wrote:
>> 
>> "struct dirent" is a kernel type here, but is a **different type** in 
>> userspace!  This means both the structure and the IOCTL number is wrong!
>> 
>> So, this adds new "struct __fat_dirent" to generate correct IOCTL
>> number.  And kernel stuff moves to under __KERNEL__.
>
> Given that the current version can't actually work without defininig
> it's own dirent and thus ioctl number symbolic name I wonder if these
> ioctls are used at all?  They must have been completely untested for
> a while, and I suspect we'd be better off just removing them.

I'm not sure whether all users doesn't use. (If user uses correct dirent
like I did to test in past, it generates correct number.)

Anyway, why is it better off?  I think, if users which copied, this
patch shouldn't have any impact, and other users can use fixed version?
-- 
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/