Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755314AbYGAL7S (ORCPT ); Tue, 1 Jul 2008 07:59:18 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753234AbYGAL7G (ORCPT ); Tue, 1 Jul 2008 07:59:06 -0400 Received: from smtp6.pp.htv.fi ([213.243.153.40]:36094 "EHLO smtp6.pp.htv.fi" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751768AbYGAL7F (ORCPT ); Tue, 1 Jul 2008 07:59:05 -0400 Date: Tue, 1 Jul 2008 14:58:46 +0300 From: Adrian Bunk To: Dmitry Torokhov , geert@linux-m68k.org, zippel@linux-m68k.org Cc: linux-m68k@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: m68k input/ff-core.c build error Message-ID: <20080701115845.GC17558@cs181140183.pp.htv.fi> References: <20080701115619.GB17558@cs181140183.pp.htv.fi> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20080701115619.GB17558@cs181140183.pp.htv.fi> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1574 Lines: 40 On Tue, Jul 01, 2008 at 02:56:19PM +0300, Adrian Bunk wrote: > Commit 656acd2bbc4ce7f224de499ee255698701396c48 > (Input: fix locking in force-feedback core) > causes the following build error on m68k: > > <-- snip --> > > ... > CC drivers/input/ff-core.o > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c: In function 'input_ff_upload': > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c:172: error: dereferencing pointer to incomplete type > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c: In function 'erase_effect': > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c:197: error: dereferencing pointer to incomplete type > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/input/ff-core.c:204: error: dereferencing pointer to incomplete type > make[3]: *** [drivers/input/ff-core.o] Error 1 > > <-- snip --> > > Not sure what exactly the problem is, the failures are the > added spin_unlock_irq(&dev->event_lock)'s. And just before I send my email Geert already sends a fix... :-) cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/