Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759546AbYGAPwE (ORCPT ); Tue, 1 Jul 2008 11:52:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752187AbYGAPvy (ORCPT ); Tue, 1 Jul 2008 11:51:54 -0400 Received: from sovereign.computergmbh.de ([85.214.69.204]:45873 "EHLO sovereign.computergmbh.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753323AbYGAPvx (ORCPT ); Tue, 1 Jul 2008 11:51:53 -0400 Date: Tue, 1 Jul 2008 17:51:52 +0200 (CEST) From: Jan Engelhardt To: Stefano Stabellini cc: linux-kernel@vger.kernel.org Subject: Re: [PATCH 1 of 2] fbcon: bgcolor fix In-Reply-To: <486A4F64.3050904@eu.citrix.com> Message-ID: References: <486A4F64.3050904@eu.citrix.com> User-Agent: Alpine 1.10 (LNX 962 2008-03-14) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 941 Lines: 27 On Tuesday 2008-07-01 17:38, Stefano Stabellini wrote: >The forth bit of the background color is the blink property bit, not the >intensity bit, as for the foreground color. >Therefore it shouldn't be included in the background color. I'm a bit skeptical, though I have not tried this. ISTR fb has the power to render full 8 bits background in addition to blinking. >--- a/drivers/video/console/fbcon.h >+++ b/drivers/video/console/fbcon.h >@@ -92,7 +92,7 @@ struct fbcon_ops { > #define attr_fgcol(fgshift,s) \ > (((s) >> (fgshift)) & 0x0f) > #define attr_bgcol(bgshift,s) \ >- (((s) >> (bgshift)) & 0x0f) >+ (((s) >> (bgshift)) & 0x07) > > /* Monochrome */ > #define attr_bold(s) \ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/