Message-ID: <486A5B02.5090205@skyrush.com>
Date: Tue, 01 Jul 2008 11:27:46 -0500
From: Joe Peterson <joe@skyrush.com>
User-Agent: Thunderbird 2.0.0.14 (X11/20080514)
MIME-Version: 1.0
To: Elias Oltmanns <eo@nebensachen.de>
CC: =?ISO-8859-1?Q?T=F6r=F6k_Edwin?= <edwintorok@gmail.com>,
       Alan Cox <alan@lxorguk.ukuu.org.uk>,
       Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: Ctrl+C doesn't interrupt process waiting for I/O
References: <48661488.10304@gmail.com> <87fxqurqpz.fsf@denkblock.local>	<486A3B4A.2090005@skyrush.com> <877ic5irsu.fsf@denkblock.local>
In-Reply-To: <877ic5irsu.fsf@denkblock.local>
Content-Type: multipart/mixed;
 boundary="------------070509060009060209020207"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2049
Lines: 61

This is a multi-part message in MIME format.
--------------070509060009060209020207
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Elias Oltmanns wrote:
> Due to my tests, 2.6.24 responds much faster to Ctrl+C than 2.6.25 does.
> The patch above makes them *feel* alike again (no hard numbers, mind).
> However, I haven't checked anything as early as 2.6.21 or before so I
> don't know whether there may have been another regression since then.

OK, thanks for checking.  Can you try the patch below?  It is almost the
same as your patch, except it reverses the order of the isig and the echo.

This causes ^C echo to work for me in both console and xterm.  Back when
I did the original patch, I was concerned this ordering could result in
the ^C echoing late, but this may not be an issue.

Let me know if the patch below fixes the issue with interrupting
processes waiting for I/O.

				Thanks, Joe

--------------070509060009060209020207
Content-Type: text/x-patch;
 name="ctrl_c.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="ctrl_c.patch"

--- linux/drivers/char/n_tty.c.orig	2008-07-01 10:48:05.000000000 -0500
+++ linux/drivers/char/n_tty.c	2008-07-01 11:20:07.000000000 -0500
@@ -759,20 +759,9 @@
 		signal = SIGTSTP;
 		if (c == SUSP_CHAR(tty)) {
 send_signal:
-			/*
-			 * Echo character, and then send the signal.
-			 * Note that we do not use isig() here because we want
-			 * the order to be:
-			 * 1) flush, 2) echo, 3) signal
-			 */
-			if (!L_NOFLSH(tty)) {
-				n_tty_flush_buffer(tty);
-				tty_driver_flush_buffer(tty);
-			}
+			isig(signal, tty, 0);
 			if (L_ECHO(tty))
 				echo_char(c, tty);
-			if (tty->pgrp)
-				kill_pgrp(tty->pgrp, signal, 1);
 			return;
 		}
 	}

--------------070509060009060209020207--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/