Date: Tue, 1 Jul 2008 12:13:43 -0700
From: Greg KH <gregkh@suse.de>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Stefan Becker <Stefan.Becker@nokia.com>, linux-usb@vger.kernel.org,
       ext David Brownell <david-b@pacbell.net>, linux-kernel@vger.kernel.org,
       Linus Torvalds <torvalds@linux-foundation.org>,
       ext Leonardo Chiquitto <leonardo.lists@gmail.com>
Subject: Re: [PATCH] USB: fix interrupt disabling for HCDs with shared
	interrupt handlers
Message-ID: <20080701191343.GA26068@suse.de>
References: <20080701182543.GA32098@suse.de> <Pine.LNX.4.44L0.0807011456370.6796-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Pine.LNX.4.44L0.0807011456370.6796-100000@iolanthe.rowland.org>
User-Agent: Mutt/1.5.16 (2007-06-09)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1298
Lines: 33

On Tue, Jul 01, 2008 at 02:59:38PM -0400, Alan Stern wrote:
> On Tue, 1 Jul 2008, Greg KH wrote:
> 
> > Hm, isn't this also an issue in 2.6.25 as well?  I've had a few very
> > strange reports of USB just locking up in 2.6.25, could this also be the
> > cause there?
> 
> It could go back a lot farther than that.  I don't think our interrupt 
> setup has been changed significantly for a long time, with one 
> exception: We added the IRQF_DISABLED flag fairly recently.  But of 
> course, we now know that it doesn't do what we expected.
> 
> It's surprising that more people haven't experienced this problem and 
> reported it.

Ok, I'll queue it up for -stable as well.

> > Alan and Dave, do you both ack this thing?  I know you've been involved
> > in creating it, just want to get the formal approval :)
> 
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> 
> There still are a few places where spaces were used instead of tabs for 
> indenting.  Aside from that it looks fine.

Thanks, I'll clean that up by hand, not a big deal :)

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/