Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759405AbYGATxp (ORCPT ); Tue, 1 Jul 2008 15:53:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754119AbYGATxe (ORCPT ); Tue, 1 Jul 2008 15:53:34 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:45455 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbYGATxd (ORCPT ); Tue, 1 Jul 2008 15:53:33 -0400 Subject: Re: [2.6 patch] remove dummy asm/kvm.h files From: David Woodhouse To: Sam Ravnborg Cc: Adrian Bunk , Christian Borntraeger , Avi Kivity , linux-arch@vger.kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: <20080701193236.GB10350@uranus.ravnborg.org> References: <20080701162716.GB32598@cs181140183.pp.htv.fi> <20080701193236.GB10350@uranus.ravnborg.org> Content-Type: text/plain Date: Tue, 01 Jul 2008 20:53:20 +0100 Message-Id: <1214942000.10393.418.camel@pmac.infradead.org> Mime-Version: 1.0 X-Mailer: Evolution 2.22.2 (2.22.2-2.fc9) Content-Transfer-Encoding: 7bit X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1640 Lines: 44 On Tue, 2008-07-01 at 21:32 +0200, Sam Ravnborg wrote: > On Tue, Jul 01, 2008 at 07:27:16PM +0300, Adrian Bunk wrote: > > This patch removes the dummy asm/kvm.h files on architectures not (yet) > > supporting KVM and uses the same conditional headers installation as > > already used for a.out.h . > > > > Also removed are superfluous install rules in the s390 and x86 Kbuild > > files (they are already in Kbuild.asm). > > > > Signed-off-by: Adrian Bunk > > I really do not like the way we implement these checks and > think this should be a kconfig option. > But we do not (yet) require a configured kernel when exporting > to userspace so this is not feasible right now. I'm _really_ dubious about doing this kind of thing through Kconfig. In the general case, we really don't want exported headers to have any differences based on the kernel configuration. Yes, I suppose it would be OK if we are very careful not to let anyone use config symbols that aren't hard-coded for the given architecture. But in practice I don't think there's any real chance that we'd manage to be careful _enough_. We'd find people using symbols they shouldn't be. > So despite the above this patch has my: > Acked-by: Sam Ravnborg > > Same for the asm/a.out patch you posted the other day. > > David - I assume you take these via your tree? I can do. -- dwmw2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/