Date: Tue, 1 Jul 2008 15:16:50 -0700
From: Andrew Morton <akpm@linux-foundation.org>
To: <Solofo.Ramangalahy@bull.net>
Cc: linux-kernel@vger.kernel.org, matthltc@us.ibm.com, cmm@us.ibm.com,
       Nadia.Derbey@bull.net, manfred@colorfullife.com,
       nickpiggin@yahoo.com.au
Subject: Re: [PATCH -mm 0/3] sysv ipc: increase msgmnb with the number of
 cpus
Message-Id: <20080701151650.f27a425a.akpm@linux-foundation.org>
In-Reply-To: <20080624093452.946878437@bull.net>
References: <20080624093452.946878437@bull.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1154
Lines: 28

On Tue, 24 Jun 2008 11:34:52 +0200
<Solofo.Ramangalahy@bull.net> wrote:

> The size in bytes of a SysV IPC message queue, msgmnb, is too small
> for large machines, but we don't want to bloat small machines.
> 
> This series change ("scale") the default value of
> /proc/sys/kernel/msgmnb.

I'm afraid I've lost track of what's happening here.  Did we come up
with an alternative to "magical positive-versus-negative number trick"?

Your patch #1 adds and uses recompute_msgmnb() without adding the
declaration to a header file.  Your patch #2 does add the
recompute_msgmnb() to a header file, so we have a window in which the
build is broken, which is bad.

recompute_msgmnb() isn't a terribly good globally-visible identifier,
btw.  It is nice to add some subsystem identifer as a prefix.  There's
little chance of this symbol colliding with anything else, so this is a
minor cosmetic thing in this case.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/