Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760878AbYGBAIy (ORCPT ); Tue, 1 Jul 2008 20:08:54 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758134AbYGBAIn (ORCPT ); Tue, 1 Jul 2008 20:08:43 -0400 Received: from qb-out-0506.google.com ([72.14.204.236]:13492 "EHLO qb-out-0506.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756337AbYGBAIl (ORCPT ); Tue, 1 Jul 2008 20:08:41 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=googlemail.com; s=gamma; h=from:to:subject:date:user-agent:cc:references:in-reply-to :mime-version:content-type:content-transfer-encoding :content-disposition:message-id; b=rzgfz0qPjecD8gKwBUnPsRaNwjRRFanWDr0wOewBSIL5QRXYa+wqmIe30QzOgSy+cv zay1iVWbcHKWC5EDbiAfKPIBqpilFdEQobIAbare/Z7cJpHt78vpmkf2rcGv9IA6fPBg DRV+xDgG5paqnIS7xrZ26CaM6uAvNENfrR3ao= From: Denys Vlasenko To: "Mike Frysinger" Subject: Re: [PATCH 5/23] make section names compatible with -ffunction-sections -fdata-sections: blackfin Date: Wed, 2 Jul 2008 02:08:33 +0200 User-Agent: KMail/1.8.2 Cc: linux-arch@vger.kernel.org, "Russell King" , "David Howells" , "Ralf Baechle" , "Lennert Buytenhek" , "Josh Boyer" , "Paul Mackerras" , "David Woodhouse" , "Andi Kleen" , torvalds@linux-foundation.org, akpm@linux-foundation.org, "Paul Gortmaker" , linux-embedded@vger.kernel.org, linux-kernel@vger.kernel.org, "Tim Bird" , "Martin Schwidefsky" , "Dave Miller" References: <200807020235.08025.vda.linux@googlemail.com> <8bd0f97a0807011558u2c02f6fcre2f3af3d5cced936@mail.gmail.com> In-Reply-To: <8bd0f97a0807011558u2c02f6fcre2f3af3d5cced936@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200807020208.33302.vda.linux@googlemail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1289 Lines: 29 On Wednesday 02 July 2008 00:58, Mike Frysinger wrote: > On Tue, Jul 1, 2008 at 8:35 PM, Denys Vlasenko wrote: > > The purpose of this patch is to make kernel buildable > > with "gcc -ffunction-sections -fdata-sections". > > This patch fixes blackfin architecture. > > the comment right above what you changed says it already works for > Blackfin. so you arent fixing it at all. > > /* This gets done first, so the glob doesn't suck it in */ > > . = ALIGN(32); > > - *(.data.cacheline_aligned) > > + *(.cacheline_aligned.data) This may pull in an unrelated data object named "cacheline_aligned" (say, a static variable in a driver). If that variable is not itself aligned to the cacheline size, it will mess up alignment of all objects in .data.cacheline_aligned which follow. Not good. To be safe from such weird and hard to debug problems it's better to not use names like .data.XXXX at all. I just uniformly renamed al such "special sections" in the kernel to .XXXXX.data -- vda -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/