Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761558AbYGBCJe (ORCPT ); Tue, 1 Jul 2008 22:09:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758091AbYGBCJX (ORCPT ); Tue, 1 Jul 2008 22:09:23 -0400 Received: from py-out-1112.google.com ([64.233.166.179]:57812 "EHLO py-out-1112.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756179AbYGBCJV (ORCPT ); Tue, 1 Jul 2008 22:09:21 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:to:subject:cc:in-reply-to:mime-version :content-type:content-transfer-encoding:content-disposition :references; b=ng7UjB4At4Vp/4WILdXH29KQswIMS5OOMO4xk1Xav9qjvP2PHUYQd8S93qNvzj64Lz Lw1SR47Q2WX3JTPvsDJEIxMlxXIANktjiWbzmdlY9LXxHJC+XcE+5HCurj27q91P7a+q lHcYGpwMIjE6PXICsXZYeJaHlQAkur8xfVfmw= Message-ID: <8bd0f97a0807011909i53a347f5me4410a24dd27d5ab@mail.gmail.com> Date: Tue, 1 Jul 2008 22:09:20 -0400 From: "Mike Frysinger" To: "Denys Vlasenko" Subject: Re: [PATCH 5/23] make section names compatible with -ffunction-sections -fdata-sections: blackfin Cc: linux-arch@vger.kernel.org, "Russell King" , "David Howells" , "Ralf Baechle" , "Lennert Buytenhek" , "Josh Boyer" , "Paul Mackerras" , "David Woodhouse" , "Andi Kleen" , torvalds@linux-foundation.org, akpm@linux-foundation.org, "Paul Gortmaker" , linux-embedded@vger.kernel.org, linux-kernel@vger.kernel.org, "Tim Bird" , "Martin Schwidefsky" , "Dave Miller" In-Reply-To: <200807020208.33302.vda.linux@googlemail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <200807020235.08025.vda.linux@googlemail.com> <8bd0f97a0807011558u2c02f6fcre2f3af3d5cced936@mail.gmail.com> <200807020208.33302.vda.linux@googlemail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1740 Lines: 37 On Tue, Jul 1, 2008 at 8:08 PM, Denys Vlasenko wrote: > On Wednesday 02 July 2008 00:58, Mike Frysinger wrote: >> On Tue, Jul 1, 2008 at 8:35 PM, Denys Vlasenko wrote: >> > The purpose of this patch is to make kernel buildable >> > with "gcc -ffunction-sections -fdata-sections". >> > This patch fixes blackfin architecture. >> >> the comment right above what you changed says it already works for >> Blackfin. so you arent fixing it at all. >> > /* This gets done first, so the glob doesn't suck it in */ >> > . = ALIGN(32); >> > - *(.data.cacheline_aligned) >> > + *(.cacheline_aligned.data) > > This may pull in an unrelated data object named "cacheline_aligned" > (say, a static variable in a driver). If that variable is not > itself aligned to the cacheline size, it will mess up alignment of all > objects in .data.cacheline_aligned which follow. Not good. > > To be safe from such weird and hard to debug problems > it's better to not use names like .data.XXXX at all. > I just uniformly renamed al such "special sections" > in the kernel to .XXXXX.data you're right of course ... i obviously hadnt thought of this. please however still abstract this stuff into the common header. i just tested the current Blackfin kernel and it does build/link/run fine with -ffunction-sections/-fdata-sections. however, --gc-sections still causes crashes (but this is because all of the .init.setup sections are flagged as unused). -mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/