Subject: Re: Bug in random32.c: all-zero outputs with probability 1/2^32,
	other seeding bugs
From: Matt Mackall <mpm@selenic.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Benoit Boissinot <bboissin@gmail.com>, linux-kernel@vger.kernel.org,
       lloyd@randombit.net, "Theodore Ts'o" <tytso@mit.edu>,
       netdev@vger.kernel.org
In-Reply-To: <20080701173405.cb28db84.akpm@linux-foundation.org>
References: <20080619153045.GC1455@randombit.net>
	 <20080701231927.GW7647@pirzuine>
	 <20080701173405.cb28db84.akpm@linux-foundation.org>
Content-Type: text/plain
Date: Tue, 01 Jul 2008 22:22:31 -0500
Message-Id: <1214968951.11311.122.camel@calx>
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1106
Lines: 31


On Tue, 2008-07-01 at 17:34 -0700, Andrew Morton wrote:
> On Wed, 2 Jul 2008 01:19:27 +0200
> Benoit Boissinot <bboissin@gmail.com> wrote:
> 
> > [who maintains random32.c ?]
> 
> ah.  I think it's ancient net code which was recently hoisted into lib/.
> So: not really anybody.
> 
> I've been hopefully cc'ing Matt and Ted in the hope of fooling them
> into looking at it.  But a netdev cc is appropriate also.

I did look at it, and it looks reasonable. So:

Acked-by: Matt Mackall <mpm@selenic.com>

Stephen Hemminger is responsible for the original code, I believe. I've
been tempted to slurp this functionality into random.c but keep getting
side-tracked into theoretical investigations of better functions, as I'm
not a big fan of the current one from either a performance or strength
perspective.

-- 
Mathematics is the supreme nostalgia of our time.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/