Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762387AbYGBDcl (ORCPT ); Tue, 1 Jul 2008 23:32:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754086AbYGBDcS (ORCPT ); Tue, 1 Jul 2008 23:32:18 -0400 Received: from xenotime.net ([66.160.160.81]:57139 "HELO xenotime.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755866AbYGBDcQ (ORCPT ); Tue, 1 Jul 2008 23:32:16 -0400 Date: Tue, 1 Jul 2008 20:32:11 -0700 From: Randy Dunlap To: Trond Myklebust Cc: "Rafael J. Wysocki" , "Mr. Charles Edward Lever" , Stephen Rothwell , linux-next@vger.kernel.org, LKML , kernel-testers@vger.kernel.org, linux-nfs@vger.kernel.org Subject: Re: inux-next: Tree for July 1 Message-Id: <20080701203211.95244ebd.rdunlap@xenotime.net> In-Reply-To: <1214959743.10317.3.camel@localhost> References: <20080702011434.6fb403d5.sfr@canb.auug.org.au> <200807012236.19400.rjw@sisk.pl> <1214959743.10317.3.camel@localhost> Organization: YPO4 X-Mailer: Sylpheed 2.5.0 (GTK+ 2.12.0; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1767 Lines: 51 On Tue, 01 Jul 2008 20:49:03 -0400 Trond Myklebust wrote: > On Tue, 2008-07-01 at 22:36 +0200, Rafael J. Wysocki wrote: > > I can't mount NFS shares with this kernel. I get something of this sort in > > dmesg and it seems to be 100% reproducible: > > > > [ 314.058858] RPC: Registered udp transport module. > > [ 314.058863] RPC: Registered tcp transport module. > > [ 314.490970] RPC: transport (0) not supported > > [ 319.246987] __ratelimit: 23 messages suppressed > > Does this patch fix the problem for you? Yes. Thanks. > ----------------------------------------------------------------------------------- > From: Trond Myklebust > NFS: Fix the mount protocol defaults for binary mounts > > Signed-off-by: Trond Myklebust > --- > > fs/nfs/super.c | 1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/fs/nfs/super.c b/fs/nfs/super.c > index e09b1c2..85fbb98 100644 > --- a/fs/nfs/super.c > +++ b/fs/nfs/super.c > @@ -1575,6 +1575,7 @@ static int nfs_validate_mount_data(void *options, > > if (!(data->flags & NFS_MOUNT_TCP)) > args->nfs_server.protocol = XPRT_TRANSPORT_UDP; > + nfs_set_transport_defaults(args); > /* N.B. caller will free nfs_server.hostname in all cases */ > args->nfs_server.hostname = kstrdup(data->hostname, GFP_KERNEL); > args->namlen = data->namlen; > > > -- --- ~Randy Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA http://linuxplumbersconf.org/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/