Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762917AbYGBHhf (ORCPT ); Wed, 2 Jul 2008 03:37:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756512AbYGBHh1 (ORCPT ); Wed, 2 Jul 2008 03:37:27 -0400 Received: from gate.crashing.org ([63.228.1.57]:59385 "EHLO gate.crashing.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759894AbYGBHhY (ORCPT ); Wed, 2 Jul 2008 03:37:24 -0400 Cc: linux-kernel@vger.kernel.org, scottwood@freescale.com, linuxppc-dev@ozlabs.org Message-Id: From: Kumar Gala To: Nye Liu In-Reply-To: <20080627200100.GA16661@mrv.com> Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Mime-Version: 1.0 (Apple Message framework v924) Subject: Re: [PATCH] POWERPC CPM: Minor cosmetic changes to udbg_putc Date: Wed, 2 Jul 2008 02:37:09 -0500 References: <20080627200100.GA16661@mrv.com> X-Mailer: Apple Mail (2.924) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 705 Lines: 23 On Jun 27, 2008, at 3:01 PM, Nye Liu wrote: > From: Nye Liu > > udbg_putc is a *function pointer* that is initialized during > udbg_init_cpm. It might not be initialized properly when called from > udbg_putc_cpm(), so (recursively) call udbg_putc_cpm() directly. > > Printing an "X" on initialization is ugly. How about a "\n" instead? > > Signed-off-by: Nye Liu > > --- Applied. I removed the "\n" per Scott's feedback. - k -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/