Message-ID: <486B47A8.3090809@suse.de>
Date: Wed, 02 Jul 2008 11:17:28 +0200
From: Hannes Reinecke <hare@suse.de>
User-Agent: Thunderbird 2.0.0.12 (X11/20080226)
MIME-Version: 1.0
To: Denys Vlasenko <vda.linux@googlemail.com>
Cc: James Bottomley <James.Bottomley@hansenpartnership.com>,
       linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
       Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/3] aic7xxx: debloat
References: <200807011848.22599.vda.linux@googlemail.com>
In-Reply-To: <200807011848.22599.vda.linux@googlemail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1186
Lines: 35

Hi Denys,

Denys Vlasenko wrote:
> Hi Hannes,
> 
> aic7xxx still contains ~30kb of dead code if pretty printing of registers
> is requested. These patches deal with it.
> 
> I did not get any feedback from you whether the approach of adding
> "dont_generate_debug_code" marker would be acceptable despite
> asking twice. I decided that it's a "Yes".
> 
Well, yes. Sort of.

Patches are okay in principle, only it would be best if you could hook
the dont_generate_debug_code marker to the AIC79XX_DEBUG_ENABLE config option.
This way anyone interested in doing sequencer debugging would still get
the full sequencer code (which can be quite helpful at times).
And it would be disabled for the unsuspecting user.

Apart from this: well done.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		      zSeries & Storage
hare@suse.de			      +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N?rnberg
GF: Markus Rex, HRB 16746 (AG N?rnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/