Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759970AbYGBJ6D (ORCPT ); Wed, 2 Jul 2008 05:58:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753789AbYGBJ5w (ORCPT ); Wed, 2 Jul 2008 05:57:52 -0400 Received: from ns2.uludag.org.tr ([193.140.100.220]:43554 "EHLO pardus.org.tr" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751660AbYGBJ5v (ORCPT ); Wed, 2 Jul 2008 05:57:51 -0400 From: "=?utf-8?q?S=2E=C3=87a=C4=9Flar?= Onur" Reply-To: caglar@pardus.org.tr Organization: =?utf-8?q?T=C3=9CB=C4=B0TAK_/?= UEKAE To: Greg KH Subject: Re: [patch 1/9] TTY: fix for tty operations bugs Date: Wed, 2 Jul 2008 12:57:44 +0300 User-Agent: KMail/1.9.9 Cc: linux-kernel@vger.kernel.org, stable@kernel.org, greg@kroah.com, Justin Forbes , Zwane Mwaikambo , "Theodore Ts'o" , Randy Dunlap , Dave Jones , Chuck Wolber , Chris Wedgwood , Michael Krufky , Chuck Ebbert , Domenico Andreoli , Willy Tarreau , Rodrigo Rubira Branco , torvalds@linux-foundation.org, akpm@linux-foundation.org, alan@lxorguk.ukuu.org.uk, Alan Cox References: <20080701151057.930340322@mini.kroah.org> <20080701151859.GB3536@suse.de> <20080701160132.GA4496@suse.de> In-Reply-To: <20080701160132.GA4496@suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Content-Disposition: inline Message-Id: <200807021257.47593.caglar@pardus.org.tr> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2076 Lines: 61 Hi Greg; 01 Tem 2008 Sal tarihinde, Greg KH şunları yazmıştı: > On Tue, Jul 01, 2008 at 08:18:59AM -0700, Greg KH wrote: > > 2.6.25-stable review patch. If anyone has any objections, please let us know. > > > > ------------------ > > > > From: Alan Cox > > > > This is fixed with the recent tty operations rewrite in mainline in a > > different way, this is a selective backport of the relevant portions to > > the -stable tree. > > > > Signed-off-by: Alan Cox > > Signed-off-by: Greg Kroah-Hartman > > > > --- > > drivers/net/hamradio/6pack.c | 2 ++ > > drivers/net/hamradio/mkiss.c | 8 ++++++-- > > drivers/net/irda/irtty-sir.c | 4 +++- > > Hm, there are a few build errors with this patch in these two files, > I'll go respin it and do a new -rc release... > > Sorry for missing this before. I still have following build error [...] drivers/net/hamradio/mkiss.c: In function 'ax_xmit': drivers/net/hamradio/mkiss.c:548: error: 'struct tty_struct' has no member named 'drivers' drivers/net/hamradio/mkiss.c:549: error: 'struct tty_struct' has no member named 'chars_in_buffer' drivers/net/hamradio/mkiss.c:552: warning: format '%s' expects type 'char *', but argument 3 has type 'int' drivers/net/hamradio/mkiss.c:552: error: expected ';' before ')' token drivers/net/hamradio/mkiss.c:552: error: expected statement before ')' token *** 4 errors, 1 warnings [...] after your commit bdd6248729d1f4a75e4623bce4f9c7737753b712 Author: Greg Kroah-Hartman Date: Tue Jul 1 09:44:04 2008 -0700 fix build error in tty patch commit to stable-queue Cheers -- S.Çağlar Onur http://cekirdek.pardus.org.tr/~caglar/ Linux is like living in a teepee. No Windows, no Gates and an Apache in house! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/