Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756582AbYGBUVq (ORCPT ); Wed, 2 Jul 2008 16:21:46 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753943AbYGBUVh (ORCPT ); Wed, 2 Jul 2008 16:21:37 -0400 Received: from khc.piap.pl ([195.187.100.11]:56878 "EHLO khc.piap.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753798AbYGBUVg (ORCPT ); Wed, 2 Jul 2008 16:21:36 -0400 To: Adrian Bunk Cc: netdev@vger.kernel.org, lkml Subject: Re: WAN: Remove dead code from wanmain.c, CONFIG_WANPIPE_MULTPPP doesn't exist References: <20080702201754.GA2145@cs181140183.pp.htv.fi> From: Krzysztof Halasa Date: Wed, 02 Jul 2008 22:21:34 +0200 In-Reply-To: <20080702201754.GA2145@cs181140183.pp.htv.fi> (Adrian Bunk's message of "Wed\, 2 Jul 2008 23\:17\:55 +0300") Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 907 Lines: 29 Adrian Bunk writes: >> -#ifdef CONFIG_WANPIPE_MULTPPP >> - pppdev = kzalloc(sizeof(struct ppp_device), GFP_KERNEL); >> - err = -ENOBUFS; >> - if (pppdev == NULL) >> - goto out; >> - pppdev->dev = kzalloc(sizeof(struct net_device), GFP_KERNEL); >> - if (pppdev->dev == NULL) { >> - kfree(pppdev); >> - err = -ENOBUFS; >> - goto out; >> - } >> - err = wandev->new_if(wandev, (struct net_device *)pppdev, cnf); >> - dev = pppdev->dev; >> -#else >> printk(KERN_INFO "%s: Wanpipe Mulit-Port PPP support has not been compiled in!\n", >> wandev->name); > > The printk() also needs some updating. Agreed. -- Krzysztof Halasa -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/